Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devhost: fix fc-devhost-vm-cleanup.service timezone handling #1306

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

osnyx
Copy link
Member

@osnyx osnyx commented Feb 26, 2025

Earlier changes regarding the deprecation of datetime.utcnow() had the consequence, that persisted isoformat timestamps now contained a timezone. Parsing these stamps again and comparing them with a naive time resulted in an error.
From now on, always compare timezoned datetime objects. Includes a migration path for naive isoformat timestamps created in earlier releases.

PL-133467

@flyingcircusio/release-managers

Release process

  • Created changelog entry using ./changelog.sh

PR release workflow (internal)

  • PR has internal ticket
  • internal issue ID (PL-…) part of branch name
  • internal issue ID mentioned in PR description text
  • ticket is on Platform agile board
  • ticket state set to Pull request ready
  • if ticket is more urgent than within the next few days, directly contact a member of the Platform team

Design notes

  • Provide a feature toggle if the change might need to be adjusted/reverted quickly depending on context. Consider whether the default should be on or off. Example: rate limiting.
  • All customer-facing features and (NixOS) options need to be discoverable from documentation. Add or update relevant documentation such that hosted and guided customers can understand it as well.

Security implications

  • Security requirements defined? (WHERE)
    • must not introduce known regressions
    • fix regression in fc-devhost
    • deployment and vm cleanup needs to work
    • consider migrations from older state of earlier releases
  • Security requirements tested? (EVIDENCE)
    • automated tests still pass
    • test-deployment of directory works
    • old vms are successfully cleaned up
    • investigated persisted VM state on platform 21.05

Earlier changes regarding the deprecation of `datetime.utcnow()` had the
consequence, that persisted isoformat timestamps now contained a
timezone. Parsing these stamps again and comparing them with a naive
time resulted in an error.
From now on, always compare timezoned datetime objects. Includes a
migration path for naive isoformat timestamps created in earlier
releases.

PL-133467
@osnyx osnyx requested a review from leona-ya February 26, 2025 14:00
@ctheune ctheune merged commit 5ae28d7 into fc-24.11-dev Feb 27, 2025
2 checks passed
@ctheune ctheune deleted the PL-133467-fix-devhost-cleanup branch February 27, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants